Merged
Conversation
|
Size Change: 0 B Total Size: 2.31 MB ℹ️ View Unchanged
|
eugene-manuilov
requested changes
Apr 6, 2026
Collaborator
eugene-manuilov
left a comment
eugene-manuilov
left a comment
There was a problem hiding this comment.
Mostly looks good, but found two minor issues. Please, take a look.
| } | ||
|
|
||
| if ( ! error ) { | ||
| registry.dispatch( CORE_SITE ).resetEligibleSubscribers(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| registry.dispatch( CORE_SITE ).resetEligibleSubscribers(); | |
| yield registry.dispatch( CORE_SITE ).resetEligibleSubscribers(); |
Collaborator
Author
There was a problem hiding this comment.
We don't use yield for dispatch, we included the rule to prevent it:
error Only plain objects should be yielded from action generator functions. dispatch always returns a Promise sitekit/no-yield-dispatch
Collaborator
There was a problem hiding this comment.
Ah... okay, didn't see it. Then: yield commonActions.await( registry.dispatch( ... ) )
Collaborator
There was a problem hiding this comment.
Actually, no, without yield, just await it to avoid possible race conditions:
commonActions.await( registry.dispatch( ... ) )
|
|
||
| if ( ! error ) { | ||
| const registry = yield commonActions.getRegistry(); | ||
| registry.dispatch( CORE_SITE ).resetEligibleSubscribers(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| registry.dispatch( CORE_SITE ).resetEligibleSubscribers(); | |
| yield registry.dispatch( CORE_SITE ).resetEligibleSubscribers(); |
Collaborator
There was a problem hiding this comment.
Same here: yield commonActions.await( registry.dispatch ( ... ) )
Collaborator
There was a problem hiding this comment.
Same here, without yield to avoid race conditions:
commonActions.await( registry.dispatch ( ... ) )
eugene-manuilov
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist